fix flaky fix-test_streamablehttp_client_resumption test #1166
+100
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
approved these changes
Jul 17, 2025
Comment on lines
+228
to
+260
| elif name == "wait_for_lock_with_notification": | ||
| # Initialize lock if not already done | ||
| if self._lock is None: | ||
| self._lock = anyio.Event() | ||
|
|
||
| # First send a notification | ||
| await ctx.session.send_log_message( | ||
| level="info", | ||
| data="First notification before lock", | ||
| logger="lock_tool", | ||
| related_request_id=ctx.request_id, | ||
| ) | ||
|
|
||
| # Now wait for the lock to be released | ||
| await self._lock.wait() | ||
|
|
||
| # Send second notification after lock is released | ||
| await ctx.session.send_log_message( | ||
| level="info", | ||
| data="Second notification after lock", | ||
| logger="lock_tool", | ||
| related_request_id=ctx.request_id, | ||
| ) | ||
|
|
||
| return [TextContent(type="text", text="Completed")] | ||
|
|
||
| elif name == "release_lock": | ||
| assert self._lock is not None, "Lock must be initialized before releasing" | ||
|
|
||
| # Release the lock | ||
| self._lock.set() | ||
| return [TextContent(type="text", text="Lock released")] | ||
|
|
There was a problem hiding this comment.
really cool idea to have the tool calls create internal locks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing the test found an bug, we should not check for
fix-test_streamablehttp_client_resumptionwhen setting as it's used for reusability and the check is done afterwards in the code anyways.